[vlc-devel] [PATCH 09/18] adaptive:fakeES: initialize the ES from the source category

[Rémi Denis-Courmont]

Le 8 juillet 2017 18:34:25 GMT+03:00, Steve Lhomme <robux4 at gmail.com> a écrit :
>On Fri, Jul 7, 2017 at 7:08 PM, Rémi Denis-Courmont <remi at remlab.net>
>wrote:
>> Le keskiviikkona 5. heinäkuuta 2017, 17.00.23 EEST Steve Lhomme a
>écrit :
>>> ---
>>>  modules/demux/adaptive/plumbing/FakeESOut.cpp   | 2 +-
>>>  modules/demux/adaptive/plumbing/FakeESOutID.cpp | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/modules/demux/adaptive/plumbing/FakeESOut.cpp
>>> b/modules/demux/adaptive/plumbing/FakeESOut.cpp index
>>> 781f2c8b6f..591e602232 100644
>>> --- a/modules/demux/adaptive/plumbing/FakeESOut.cpp
>>> +++ b/modules/demux/adaptive/plumbing/FakeESOut.cpp
>>> @@ -91,7 +91,7 @@ void FakeESOut::setExtraInfoProvider(
>>> ExtraFMTInfoInterface *extra ) FakeESOutID * FakeESOut::createNewID(
>const
>>> es_format_t *p_fmt )
>>>  {
>>>      es_format_t fmtcopy;
>>> -    es_format_Init( &fmtcopy, 0, 0 );
>>> +    es_format_Init( &fmtcopy, p_fmt->i_cat, 0 );
>>>      es_format_Copy( &fmtcopy, p_fmt );
>>>      fmtcopy.i_group = 0; /* Always ignore group for adaptive */
>>>      fmtcopy.i_id = -1;
>>> diff --git a/modules/demux/adaptive/plumbing/FakeESOutID.cpp
>>> b/modules/demux/adaptive/plumbing/FakeESOutID.cpp index
>>> 30b5eba19e..29ef239776 100644
>>> --- a/modules/demux/adaptive/plumbing/FakeESOutID.cpp
>>> +++ b/modules/demux/adaptive/plumbing/FakeESOutID.cpp
>>> @@ -32,7 +32,7 @@ FakeESOutID::FakeESOutID( FakeESOut *fakeesout,
>const
>>> es_format_t *p_fmt ) , p_real_es_id( NULL )
>>>      , pending_delete( false )
>>>  {
>>> -    es_format_Init( &fmt, 0, 0 );
>>> +    es_format_Init( &fmt, p_fmt->i_cat, 0 );
>>>      es_format_Copy( &fmt, p_fmt );
>>>  }
>>
>> This was and remains pointless. es_format_Copy() discards the output
>content.
>
>If types were strongly enforced, you couldn't pass 0 here, it should
>always be a category. Also a module should not change the ES category
>(it seems visualisation filters don't do that but I might be wrong).
>Once the ES is created it should not be changed.
>
>> --
>> 雷米‧德尼-库尔蒙
>> https://www.remlab.net/
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Yes and ?
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170708/39120672/attachment.html>