[vlc-devel] [PATCH] demux/adaptive: fix incorrect PCR

[Francois Cartegnie]

Le 07/07/2017 à 05:56, Zhao Zhili a écrit :
> ---
>  modules/demux/adaptive/plumbing/FakeESOut.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules/demux/adaptive/plumbing/FakeESOut.cpp
> b/modules/demux/adaptive/plumbing/FakeESOut.cpp
> index 781f2c8..3ae04a4 100644
> --- a/modules/demux/adaptive/plumbing/FakeESOut.cpp
> +++ b/modules/demux/adaptive/plumbing/FakeESOut.cpp
> @@ -378,6 +378,7 @@ int FakeESOut::esOutControl_Callback(es_out_t *fakees,
> int i_query, va_list args
>              else
>                  i_group = 0;
>              int64_t  pcr = va_arg( args, int64_t );
> +            me->checkTimestampsStart( pcr );
>              pcr += me->getTimestampOffset();
>              AbstractCommand *command =
> me->commandsqueue->factory()->createEsOutControlPCRCommand( i_group, pcr );
>              if( likely(command) )

I don't know what you're trying to fix, but that implies a lot of tests.

Since pcr in adaptive is only used for stream progress, that means you
have an incorrect buffering level bug.

Francois