[vlc-devel] [PATCH 13/16] mp4: read and save ambisonics metadata from the Google specification

[Francois Cartegnie]

Le 07/07/2017 à 16:02, Thomas Guillem a écrit :

> +static int MP4_ReadBox_SA3D( stream_t *p_stream, MP4_Box_t *p_box )
> +{
> +    MP4_READBOX_ENTER( MP4_Box_data_SA3D_t, NULL );
> +
> +    uint8_t i_version;
> +    MP4_GET1BYTE( i_version );
> +    if ( i_version != 0 )
> +        MP4_READBOX_EXIT( 0 );
> +
> +    MP4_GET1BYTE( p_box->data.p_SA3D->i_ambisonic_type );
> +    MP4_GET4BYTES( p_box->data.p_SA3D->i_ambisonic_order );
> +    MP4_GET1BYTE( p_box->data.p_SA3D->i_ambisonic_channel_ordering );
> +    MP4_GET1BYTE( p_box->data.p_SA3D->i_ambisonic_normalization );

Exit now or handle loop on ~~ UIN32T_MAX

> +    MP4_GET4BYTES( p_box->data.p_SA3D->i_num_channels );
> +    for (unsigned i = 0; i < p_box->data.p_SA3D->i_num_channels; i++)
> +    {
> +        uint8_t i_channel_map;
> +        VLC_UNUSED( i_channel_map );
> +        MP4_GET1BYTE( i_channel_map );
> +    }
> +
> +    MP4_READBOX_EXIT( 1 );

Francois