[vlc-devel] [PATCH 19/25] codec:jpeg: fix the returned error when initializing fails

[Steve Lhomme]

On Tue, Jul 11, 2017 at 10:58 AM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> Le 10/07/2017 à 16:52, Steve Lhomme a écrit :
>> ---
>>  modules/codec/jpeg.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/codec/jpeg.c b/modules/codec/jpeg.c
>> index c3119db968..0c249c0f0c 100644
>> --- a/modules/codec/jpeg.c
>> +++ b/modules/codec/jpeg.c
>> @@ -582,7 +582,7 @@ error:
>>      free(p_row_pointers);
>>
>>      block_Release(p_block);
>> -    return VLCDEC_SUCCESS;
>> +    return VLCDEC_ECRITICAL;
>>  }
>
> I don't see why a single corrupted picture would kill the decoder for good.

I see. But then this code is misleading:
http://git.videolan.org/?p=vlc.git;a=blob;f=src/input/decoder.c;h=9678a1ed5f8b8d97689f6150a1ef2e25f71bde3e;hb=HEAD#l1325

Maybe there should be a way for the decoder it didn't decode anything.
Otherwise the stats are wrong.

> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel