[vlc-devel] [PATCH 2/2] es: replace i_original_channels with i_stereo_mode

RĂ©mi Denis-Courmont remi at remlab.net
Tue Jul 11 15:29:28 CEST 2017

On mardi 11 juillet 2017 10:01:34 EEST Thomas Guillem wrote:
> The i_original_channels value (that is now i_stereo_mode) should not be used
> by aout modules, and shouldn't be set by input if there is no special
> stereo mode.
> If accepeted, this commits will be splitted in the following way:
>  - One commit per module that remove the usage of i_original_channels when
> not needed at all.
>  - One big commit that replace i_original_channels with i_stereo_mode and
> that changes few modules (mpg/a52/dca/dts/filters/core).

I have tried to move the original channels to a proper set of flags already. 
But I failed everytime, because I never understood what the channel mask 
within original channels was exactly meant to be. As far as I could tell, it 
was simply three flags with the channels identical to the physical mask :(

Also, if you want to rationalize this, there is really only one flag that 
belongs there (Dolby). Reverse stereo could just as well be fixed by reordering 
in the decoder (easy). And in principles, dual-mono should be two separate 
audio ES's (less easy).

More information about the vlc-devel mailing list