[vlc-devel] [PATCH] decklink: no need to Clean() the video_format_t before Init()

[Francois Cartegnie]

Le 12/07/2017 à 16:51, Steve Lhomme a écrit :
> ---
>  modules/video_output/decklink.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/modules/video_output/decklink.cpp b/modules/video_output/decklink.cpp
> index 35cb1ada38..c876b2e8b6 100644
> --- a/modules/video_output/decklink.cpp
> +++ b/modules/video_output/decklink.cpp
> @@ -445,7 +445,6 @@ static picture_t * CreateNoSignalPicture(vlc_object_t *p_this, const video_forma
>      if (png)
>      {
>          video_format_Clean(&dummy);
> -        video_format_Init(&dummy, 0);
>          video_format_Copy(&dummy, fmt);
>          p_pic = image_Convert(img, png, &in, &dummy);
>          if(!video_format_IsSimilar(&dummy, fmt))
> 

Unless pf_readurl has const fmt, that's not possible.

Francois