[vlc-devel] [PATCH 6/9] modules:packetizers: no need to initialize the fmt_out anymore

[Steve Lhomme]

On Wed, Jul 12, 2017 at 5:32 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On mercredi 12 juillet 2017 16:54:09 EEST Steve Lhomme wrote:
>> If it's the same as the source. Less boilerplate code is good.
>
> This looks prone to leaks in practice, as the principle of least surprise
> hints that the output format contains no memory allocation at start

I don't understand that "principle" and how it applies here. Having
the copy (and cleaning if needed) in one location seems to be less
prone to leaks. Having successive packetizers deal with it is very
prone to leaks.

> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel