[vlc-devel] [PATCH] vlc_es: add more documentation on es_format_Copy

Steve Lhomme robux4 at gmail.com
Thu Jul 13 08:23:53 CEST 2017


On Wed, Jul 12, 2017 at 6:04 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> Le 12/07/2017 à 16:51, Steve Lhomme a écrit :
>> It must copy to an unitialized structure or one that was cleaned before.
>>
>> The result should always be checked as there are allocations that can fail but
>> it's not safe for now given the state of the rest of the code.
>
> Conditional use will prevent API cleanup.
> For unitialized struct, that should be a dedicated function (*From()).

I'm fine with having a define of es_format_InitFrom() to
es_format_Copy(). It makes things a little more readable. It also
makes the distinction with es_format_Replace() more obvious.

> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list