[vlc-devel] [PATCH 4/4] stream_extractor:archive: use the static linking on Windows

[Rémi Denis-Courmont]

Le 19 juillet 2017 14:46:04 GMT+08:00, Steve Lhomme <robux4 at videolabs.io> a écrit :
>The library is built as static so we need to tell it when compiling
>too.
>---
> modules/stream_extractor/archive.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/modules/stream_extractor/archive.c
>b/modules/stream_extractor/archive.c
>index b2bf4f9d47..29ab9d15e9 100644
>--- a/modules/stream_extractor/archive.c
>+++ b/modules/stream_extractor/archive.c
>@@ -32,6 +32,10 @@
> #include <vlc_dialog.h>
> #include <vlc_input_item.h>
> 
>+#ifdef _WIN32
>+#define LIBARCHIVE_STATIC
>+#endif
>+
> #include <assert.h>
> #include <archive.h>
> #include <archive_entry.h>
>-- 
>2.12.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Now thay seems out of place. Why should the code assume that the library is built a certain way?
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170719/89313e47/attachment.html>