[vlc-devel] [PATCH 1/2] direct3d11: only report leaks when there's a debugger

[Steve Lhomme]

It seems plenty of people have issues with d3d11_1sdklayers.dll being present
but not usable.
If a dev has the issue he can always disable this code section for testing.

In UWP we can assume it's present with MS build and no debug with mingw

--
replaces https://patches.videolan.org/patch/17553/
- fix UWP build
---
 modules/video_output/win32/direct3d11.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/modules/video_output/win32/direct3d11.c b/modules/video_output/win32/direct3d11.c
index 9da636203f..f94328fbc3 100644
--- a/modules/video_output/win32/direct3d11.c
+++ b/modules/video_output/win32/direct3d11.c
@@ -1469,10 +1469,15 @@ static int Direct3D11Open(vout_display_t *vd, video_format_t *fmt)
     HRESULT hr = S_OK;
 
 # if !defined(NDEBUG)
-    HINSTANCE sdklayer_dll = LoadLibrary(TEXT("d3d11_1sdklayers.dll"));
-    if (sdklayer_dll) {
-        creationFlags |= D3D11_CREATE_DEVICE_DEBUG;
-        FreeLibrary(sdklayer_dll);
+#  if !VLC_WINSTORE_APP
+    if (IsDebuggerPresent())
+#  endif
+    {
+        HINSTANCE sdklayer_dll = LoadLibrary(TEXT("d3d11_1sdklayers.dll"));
+        if (sdklayer_dll) {
+            creationFlags |= D3D11_CREATE_DEVICE_DEBUG;
+            FreeLibrary(sdklayer_dll);
+        }
     }
 # endif
 
-- 
2.12.1