[vlc-devel] [PATCH 1/2] vdpau: add vdp_get_gpa

Rémi Denis-Courmont remi at remlab.net
Thu Jul 20 16:12:58 CEST 2017


On jeudi 20 juillet 2017 16:04:16 EEST Victorien Le Couviour--Tuffet wrote:
> On Thu, Jul 20, 2017 at 04:10:27PM +0300, Rémi Denis-Courmont wrote:
> > On jeudi 20 juillet 2017 14:33:43 EEST Victorien Le Couviour--Tuffet 
wrote:
> > > Save the VdpGetProcAddress within the instance.
> > 
> > Nack. We already have, or at least are supposed to have, wrappers for all
> > VDPAU functions (and the interop functions are obtained from GL, not
> > VDPAU).
> I'm not using the VdpGPA to retrieve any VDPAU or GL interop functions, but
> to intialize the interop.

I get that. And lets leave aside the design choice of exposing the GPA to GL, 
or exposing GL init to the VDPAU wrapper. Still, you can already get the 
driver GPA with the existing functions, since you can request it through teh 
GPA (wrapper). Thus this patch seems entirely unnecessary.

-- 
Rémi Denis-Courmont


More information about the vlc-devel mailing list