[vlc-devel] [PATCH 2/3] service_discovery: Improve debug log messages

[Rémi Denis-Courmont]

Le tiistaina 25. heinäkuuta 2017, 18.48.31 EEST Marvin Scholz a écrit :
> ---
>  src/playlist/services_discovery.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/playlist/services_discovery.c
> b/src/playlist/services_discovery.c index b3c6f23ff8..d041c728b2 100644
> --- a/src/playlist/services_discovery.c
> +++ b/src/playlist/services_discovery.c
> @@ -50,7 +50,7 @@ static void playlist_sd_item_added(services_discovery_t
> *sd, playlist_item_t *node;
>      const char *longname = (sd->description != NULL) ? sd->description :
> "?";
> 
> -    msg_Dbg(sd, "adding %s", p_input->psz_name ? p_input->psz_name :
> "(null)"); +    msg_Dbg(sd, "adding sd item: %s", p_input->psz_name ?
> p_input->psz_name : "(null)");
> 
>      playlist_Lock(playlist);
>      if (sds->node == NULL)
> @@ -83,11 +83,13 @@ static void
> playlist_sd_item_removed(services_discovery_t *sd, playlist_t *p_playlist =
> (playlist_t *)sd->obj.parent;
>      playlist_item_t *node, *item;
> 
> +    msg_Dbg(sd, "removing sd item: %s", p_input->psz_name ?
> p_input->psz_name : "(null)"); +
>      PL_LOCK;
>      item = playlist_ItemGetByInput(p_playlist, p_input);
>      if (unlikely(item == NULL))
>      {
> -        msg_Err(sd, "removing item not added"); /* SD plugin bug */
> +        msg_Err(sd, "removing sd item not added"); /* SD plugin bug */
>          PL_UNLOCK;
>          return;
>      }

I don´t really see the point. It just makes log messages longer. It should be 
obvious from the context object that this is SD.

And even regardless, SD is an accronym, not a lowercase noun.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/