[vlc-devel] [PATCH 1/3] bonjour: clarify log messages and use correct levels

[Marvin Scholz]

On 25 Jul 2017, at 20:18, Rémi Denis-Courmont wrote:

> Le tiistaina 25. heinäkuuta 2017, 18.48.30 EEST Marvin Scholz a 
> écrit :
>> Nearly all messages had level Info, which is unnecessary.
>> ---
>>  modules/services_discovery/bonjour.m | 17 +++++++----------
>>  1 file changed, 7 insertions(+), 10 deletions(-)
>>
>> diff --git a/modules/services_discovery/bonjour.m
>> b/modules/services_discovery/bonjour.m index 6f7261e5d6..bca7a23d42 
>> 100644
>> --- a/modules/services_discovery/bonjour.m
>> +++ b/modules/services_discovery/bonjour.m
>> @@ -288,7 +285,7 @@ - (void)netServiceDidResolveAddress:(NSNetService
>> *)aNetService
>>
>>  - (void)netService:(NSNetService *)aNetService 
>> didNotResolve:(NSDictionary
>> *)errorDict {
>> -    msg_Dbg(_p_this, "failed to resolve: %s", [aNetService.name
>> UTF8String]);
>> +    msg_Warn(_p_this, "service resolve failed: %s,
>> removing", [aNetService.name UTF8String]); [_rawNetServices
>> removeObject:aNetService];
>>  }
>
> You probably mean resolution, not resolve...

Thanks, indeed. Sent a new patchset which hopefully addresses the
other things you pointed out too.
>
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel