[vlc-devel] [vlc-commits] imem: fix warning

[Jean-Baptiste Kempf]

Hello,

On Tue, 25 Jul 2017, at 08:07, Tristan Matthews wrote:
> On Tue, Jul 25, 2017 at 1:34 AM, Steve Lhomme <robux4 at gmail.com> wrote:
> > On Mon, Jul 24, 2017 at 6:32 PM, Rémi Denis-Courmont <git at videolan.org> wrote:
> >> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Jul 24 19:19:00 2017 +0300| [5efc79cf91cfb9b151e7e47de3a4f589116293df] | committer: Rémi Denis-Courmont
> >>
> >> imem: fix warning
> >>
> >>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5efc79cf91cfb9b151e7e47de3a4f589116293df
> >> ---
> >>
> >>  modules/access/imem.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/modules/access/imem.c b/modules/access/imem.c
> >> index 08426eafde..09a74f1c15 100644
> >> --- a/modules/access/imem.c
> >> +++ b/modules/access/imem.c
> >> @@ -403,6 +403,7 @@ static inline int GetCategory(vlc_object_t *object)
> >>          return SPU_ES;
> >>      default:
> >>          msg_Err(object, "Invalid ES category");
> >> +        /* fall through */
> >
> > How does adding a comment "fix a warning" ?
> 
> See e.g., "-Wimplicit-fallthrough=3" in gcc-7. [1]

Do we have a buildbot/jenkins activating this warning, btw?

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734