[vlc-devel] [PATCH] macosx: remove noise filter from GUI
Victorien Le Couviour--Tuffet
victorien.lecouviour.tuffet at gmail.com
Wed Jul 26 14:33:03 CEST 2017
This filter has been removed between 1.1.13 and 2.0.0.
Closes #18483.
---
modules/gui/macosx/UI/VideoEffects.xib | 13 -------------
modules/gui/macosx/VLCVideoEffectsWindowController.h | 2 --
modules/gui/macosx/VLCVideoEffectsWindowController.m | 8 --------
3 files changed, 23 deletions(-)
diff --git a/modules/gui/macosx/UI/VideoEffects.xib b/modules/gui/macosx/UI/VideoEffects.xib
index a9adf7e4bb..4b5607b219 100644
--- a/modules/gui/macosx/UI/VideoEffects.xib
+++ b/modules/gui/macosx/UI/VideoEffects.xib
@@ -73,7 +73,6 @@
<outlet property="grainSlider" destination="69" id="2P8-j4-XXS"/>
<outlet property="invertCheckbox" destination="300" id="5a9-qz-qdw"/>
<outlet property="motiondetectCheckbox" destination="254" id="Yh5-OT-vbA"/>
- <outlet property="noiseCheckbox" destination="262" id="jaY-lZ-bhE"/>
<outlet property="posterizeCheckbox" destination="213" id="JeQ-gc-dJ5"/>
<outlet property="posterizeLabel" destination="240" id="L5o-pL-E90"/>
<outlet property="posterizeStepper" destination="234" id="Xbv-jQ-dtJ"/>
@@ -1162,16 +1161,6 @@
<action selector="enablePsychedelic:" target="-2" id="0oR-yp-Qnb"/>
</connections>
</button>
- <button translatesAutoresizingMaskIntoConstraints="NO" id="262">
- <rect key="frame" x="6" y="10" width="52" height="18"/>
- <buttonCell key="cell" type="check" title="Noise" bezelStyle="regularSquare" imagePosition="left" alignment="left" controlSize="small" inset="2" id="263" customClass="VLCHUDCheckboxCell">
- <behavior key="behavior" changeContents="YES" doesNotDimImage="YES" lightByContents="YES"/>
- <font key="font" metaFont="smallSystem"/>
- </buttonCell>
- <connections>
- <action selector="enableNoise:" target="-2" id="KKk-f4-K9A"/>
- </connections>
- </button>
<button translatesAutoresizingMaskIntoConstraints="NO" id="300">
<rect key="frame" x="222" y="10" width="88" height="18"/>
<buttonCell key="cell" type="check" title="Invert colors" bezelStyle="regularSquare" imagePosition="left" alignment="left" controlSize="small" inset="2" id="301" customClass="VLCHUDCheckboxCell">
@@ -1502,7 +1491,6 @@
<constraint firstItem="203" firstAttribute="leading" secondItem="204" secondAttribute="leading" id="4mQ-2f-Qic"/>
<constraint firstItem="279" firstAttribute="leading" secondItem="243" secondAttribute="trailing" constant="8" id="BDq-qY-w9m"/>
<constraint firstItem="256" firstAttribute="leading" secondItem="254" secondAttribute="leading" id="ITR-7T-avj"/>
- <constraint firstItem="243" firstAttribute="leading" secondItem="262" secondAttribute="leading" id="MSk-KY-Ehw"/>
<constraint firstItem="279" firstAttribute="leading" secondItem="300" secondAttribute="leading" id="O8e-w0-Yw7"/>
<constraint firstItem="278" firstAttribute="leading" secondItem="279" secondAttribute="leading" id="OzU-Vi-ao3"/>
<constraint firstItem="207" firstAttribute="top" secondItem="203" secondAttribute="top" id="QKr-fj-vSY"/>
@@ -1515,7 +1503,6 @@
<constraint firstItem="254" firstAttribute="top" secondItem="218" secondAttribute="bottom" constant="6" id="X4R-Jg-fee"/>
<constraint firstItem="256" firstAttribute="top" secondItem="254" secondAttribute="bottom" constant="3" id="ZfS-bV-nS5"/>
<constraint firstItem="271" firstAttribute="leading" secondItem="272" secondAttribute="leading" id="bL3-Wr-Y0U"/>
- <constraint firstItem="262" firstAttribute="top" secondItem="243" secondAttribute="bottom" constant="5" id="chw-Qb-hFM"/>
<constraint firstItem="272" firstAttribute="leading" secondItem="11" secondAttribute="leading" constant="11" id="dCG-fm-mE8"/>
<constraint firstItem="218" firstAttribute="height" secondItem="207" secondAttribute="height" id="gKW-QH-gTo"/>
<constraint firstItem="213" firstAttribute="leading" secondItem="207" secondAttribute="leading" id="gLR-0l-e9q"/>
diff --git a/modules/gui/macosx/VLCVideoEffectsWindowController.h b/modules/gui/macosx/VLCVideoEffectsWindowController.h
index 243fc88a26..f09a5ada2a 100644
--- a/modules/gui/macosx/VLCVideoEffectsWindowController.h
+++ b/modules/gui/macosx/VLCVideoEffectsWindowController.h
@@ -108,7 +108,6 @@
@property (readwrite, weak) IBOutlet NSTextField *sepiaLabel;
@property (readwrite, weak) IBOutlet NSTextField *sepiaTextField;
@property (readwrite, weak) IBOutlet NSStepper *sepiaStepper;
- at property (readwrite, weak) IBOutlet NSButton *noiseCheckbox;
@property (readwrite, weak) IBOutlet NSButton *gradientCheckbox;
@property (readwrite, weak) IBOutlet NSTextField *gradientModeLabel;
@property (readwrite, weak) IBOutlet NSPopUpButton *gradientModePopup;
@@ -205,7 +204,6 @@
- (IBAction)thresholdModifierChanged:(id)sender;
- (IBAction)enableSepia:(id)sender;
- (IBAction)sepiaModifierChanged:(id)sender;
-- (IBAction)enableNoise:(id)sender;
- (IBAction)enableGradient:(id)sender;
- (IBAction)gradientModifierChanged:(id)sender;
- (IBAction)enableExtract:(id)sender;
diff --git a/modules/gui/macosx/VLCVideoEffectsWindowController.m b/modules/gui/macosx/VLCVideoEffectsWindowController.m
index 539e2143f5..d9d8b1a04f 100644
--- a/modules/gui/macosx/VLCVideoEffectsWindowController.m
+++ b/modules/gui/macosx/VLCVideoEffectsWindowController.m
@@ -241,7 +241,6 @@
[_thresholdSimilarityLabel setStringValue:_NS("Similarity")];
[_sepiaCheckbox setTitle:_NS("Sepia")];
[_sepiaLabel setStringValue:_NS("Intensity")];
- [_noiseCheckbox setTitle:_NS("Noise")];
[_gradientCheckbox setTitle:_NS("Gradient")];
[_gradientModeLabel setStringValue:_NS("Mode")];
[_gradientModePopup removeAllItems];
@@ -459,7 +458,6 @@
[_puzzleCheckbox setState: (NSInteger)strstr(psz_vfilters, "puzzle")];
[_thresholdCheckbox setState: (NSInteger)strstr(psz_vfilters, "colorthres")];
[_sepiaCheckbox setState: (NSInteger)strstr(psz_vfilters, "sepia")];
- [_noiseCheckbox setState: (NSInteger)strstr(psz_vfilters, "noise")];
[_gradientCheckbox setState: (NSInteger)strstr(psz_vfilters, "gradient")];
[_extractCheckbox setState: (NSInteger)strstr(psz_vfilters, "extract")];
[_invertCheckbox setState: (NSInteger)strstr(psz_vfilters, "invert")];
@@ -481,7 +479,6 @@
[_puzzleCheckbox setState: NSOffState];
[_thresholdCheckbox setState: NSOffState];
[_sepiaCheckbox setState: NSOffState];
- [_noiseCheckbox setState: NSOffState];
[_gradientCheckbox setState: NSOffState];
[_extractCheckbox setState: NSOffState];
[_invertCheckbox setState: NSOffState];
@@ -1131,11 +1128,6 @@
[[VLCCoreInteraction sharedInstance] setVideoFilterProperty: "sepia-intensity" forFilter: "sepia" withValue: getWidgetIntValue(sender)];
}
-- (IBAction)enableNoise:(id)sender
-{
- [[VLCCoreInteraction sharedInstance] setVideoFilter: "noise" on: [_noiseCheckbox state]];
-}
-
- (IBAction)enableGradient:(id)sender
{
BOOL b_state = [_gradientCheckbox state];
--
2.13.1
More information about the vlc-devel
mailing list