[vlc-devel] [PATCH] demux: adaptive: fix inverted logic and don't do wait in a loop

Zhao Zhili wantlamy at gmail.com
Wed Jul 26 15:06:22 CEST 2017


On Wed, Jul 26, 2017 at 8:02 PM, Francois Cartegnie <fcvlcdev at free.fr>
wrote:

> Le 26/07/2017 à 13:43, Zhao Zhili a écrit :
>
> >              mutex_cleanup_push(&lock);
> > -            while(vlc_cond_timedwait(&waitcond, &lock, i_deadline) == 0
> > -                 && i_deadline < mdate());
> > +            vlc_cond_timedwait(&waitcond, &lock, i_deadline);
> >              vlc_cleanup_pop();
>
> The loop is there to deal with spurious wakeups.
>
>
There is a chance it need to wakeup early and do bufferize again. I think
it's better
be in advance when awakening than late.



> Francois
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170726/703cb533/attachment.html>


More information about the vlc-devel mailing list