[vlc-devel] [PATCH 1/2] es_out: ask for decoder drain on es_out_Del

[Francois Cartegnie]

Le 28/07/2017 à 17:40, Steve Lhomme a écrit :
> On Fri, Jul 28, 2017 at 5:06 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
>> because when the es deletion is triggered by
>> demuxer and not on EOF, it enters a dead loop
>> waiting for input_DecoderIsEmpty (p_owner->drained).
>> non set p_owner->draining can't trigger p_owner->drained.
> 
> Doesn't that mean the remaining data for that ES that are not yet
> decoder/rendered will be lost ? That doesn't seem right for gapless
> playback.

That does not differ from current behavior. Drain is only done on EOF.

The regressions introduced by the removal of aout_IsEmpty() being when
GET_EMPTY is called by demuxer or on non EOF es_out_Del. (waits for a
drain which was not initiated)

Francois