[vlc-devel] [PATCH] demux: plug leaks

[Rémi Denis-Courmont]

Le maanantaina 31. heinäkuuta 2017, 18.28.40 EEST Shaleen Jain a écrit :
> Regards,
> Shaleen Jain
> 
> On Mon, Jul 31, 2017 at 6:09 PM, Francois Cartegnie <fcvlcdev at free.fr>
> 
> wrote:
> > Le 31/07/2017 à 14:08, Shaleen Jain a écrit :
> >>  +    es_out_Del( p_demux->out, p_sys->p_sub );
> >>  +    es_out_Del( p_demux->out, p_sys->p_audio );
> >>  +    es_out_Del( p_demux->out, p_sys->p_video );
> >>  
> >>       free( p_sys );
> > 
> > ES are automatically deleted at the end.
> 
> End of what?

End of stream.

There is a temporal leak if you remove a slave demux before the end of stream. 
But that is more of a side effect of missing master/slave ES output, than a 
bug of its own (it won´t cause a memory leak in the end).

> These are es_out_id_t created by es_out_Add which I believe have to be
> freed with es_out_Del.
> 
> Most of the modules free it except the few ones above.

I could be wrong but AFAIR a lot of modules don´t delete their ES's 
explicitly.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/