[vlc-devel] [PATCH 2/3] video_chroma: chain: add a new filter converter

Rémi Denis-Courmont remi at remlab.net
Thu Jun 1 20:43:22 CEST 2017


Le perjantaina 26. toukokuuta 2017, 16.27.00 EEST Thomas Guillem a écrit :
> This new "chain" video filter will try to add a video converter before the
> requested video filter.

I am not sure I understand what this is supposed to do.

If you want to run a filter with an input conversion, in principles, you can 
simply make it override its input format and return VLC_SUCCESS. You probably 
also want the output format copied from the output format.

So I don´t see why you need to change either the core or the chain converter. 
And not only I don´t see the need, but I very much suspect that it breaks the 
use case whereby a filter legitimately refuses to start by returning an error.

E.g. deinterlacer on RGB input, VDPAU filters on CPU chroma...

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/



More information about the vlc-devel mailing list