[vlc-devel] [PATCH 0/3] fix snapshot of opaque pictures

Thomas Guillem thomas at gllm.fr
Mon Jun 5 16:22:03 CEST 2017

picture_Copy() that is used by vout_snapshot_Set() doesn't work for opaque
pictures since it doesn't copy the private members of the picture (context or

That's why we need to convert the opaque picture to a CPU one from the
vout_snapshot_Set() function. This function will now try convert the picture to
an unknown chroma (fmt.i_chroma = 0). The video chain converter will now handle
such invalid chroma, and will use its internal list to test every allowed


Steve Lhomme (1):
  snapshot: always use the picture format

Thomas Guillem (2):
  chroma: chain: handle unknown chroma
  snapshot: fix copy of opaque pictures

 modules/video_chroma/chain.c    | 27 ++++++++++++++++
 src/video_output/snapshot.c     | 69 ++++++++++++++++++++++++++++++++++++-----
 src/video_output/snapshot.h     |  5 +--
 src/video_output/video_output.c |  2 +-
 4 files changed, 90 insertions(+), 13 deletions(-)


More information about the vlc-devel mailing list