[vlc-devel] [PATCH 3/3] snapshot: fix copy of opaque pictures

Rémi Denis-Courmont remi at remlab.net
Mon Jun 5 18:10:11 CEST 2017


Le maanantaina 5. kesäkuuta 2017, 19.02.22 EEST Rémi Denis-Courmont a écrit :
> Stating the obvious here, but the patch does not do what the commit title
> implies.
> 
> AFAICT, there are essentially only two way to handle copying of pictures
> with an opaque context: the very obvious but very slow way and the rather
> obvious and very fast way. And that means either adding a copy callback
> (slow), or replacing the destroy callback with a pair hold/release
> callbacks.

(The "correct" way is to perform a shallow copy of the context. A pure 
reference counter would interfere with context changes in VDPAU filters.)

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/



More information about the vlc-devel mailing list