[vlc-devel] [PATCH 1/3] chroma: chain: handle unknown chroma

[Thomas Guillem]

On Mon, Jun 5, 2017, at 17:54, Rémi Denis-Courmont wrote:
> Le maanantaina 5. kesäkuuta 2017, 16.22.04 EEST Thomas Guillem a écrit :
> > If the filter output chroma is not set, this module can be used to find the
> > best chroma available (via the pi_allowed_chromas list).
> > ---
> >  modules/video_chroma/chain.c | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/modules/video_chroma/chain.c b/modules/video_chroma/chain.c
> > index 3cd4e9f544..28e855c294 100644
> > --- a/modules/video_chroma/chain.c
> > +++ b/modules/video_chroma/chain.c
> > @@ -262,6 +262,33 @@ static int BuildChromaChain( filter_t *p_filter )
> >              i_chroma == p_filter->fmt_out.i_codec )
> >              continue;
> > 
> > +        if( p_filter->fmt_out.video.i_chroma == 0 )
> 
> That should never happen. AFAIK, most filters (correctly) assume that the 
> output format is valid by default.
> 
> Something is wrong somewhere else if this is ever allowed to occur.

It happens only with my third patch, I agree, it's better to assume the
chroma is always valid.

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel