[vlc-devel] [PATCH] contrib: use the nightly builds as prebuilt on Windows

[Steve Lhomme]

On Mon, Jun 12, 2017 at 10:20 AM, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
> On Mon, Jun 12, 2017, at 10:09 AM, Rémi Denis-Courmont wrote:
>> On June 12, 2017 11:04:23 AM GMT+03:00, Steve Lhomme <robux4 at gmail.com>
>> wrote:
>> >Up ?
>> >They are way more up to date than the old prebuilt which are unusable
>> >right now. It also makes it easier to update when there are changes in
>> >the master. Given I never managed to update all the contribs on
>> >mingw32. I always have to rely on parts of the prebuilt.
>> >
>> >On Wed, Oct 26, 2016 at 5:42 PM, Steve Lhomme <robux4 at videolabs.io>
>> >wrote:
>> >> ---
>> >>  contrib/src/main.mak | 8 ++++++++
>> >>  1 file changed, 8 insertions(+)
>> >>
>> >> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> >> index da3eebf..d5c3668 100644
>> >> --- a/contrib/src/main.mak
>> >> +++ b/contrib/src/main.mak
>> >> @@ -42,6 +42,10 @@ ARCH := $(shell $(SRC)/get-arch.sh $(HOST))
>> >>
>> >>  ifeq ($(ARCH)-$(HAVE_WIN32),x86_64-1)
>> >>  HAVE_WIN64 := 1
>> >> +CONTRIB_DIR := win64
>> >> +endif
>> >> +ifeq ($(ARCH)-$(HAVE_WIN32),i386-1)
>> >> +CONTRIB_DIR := win32
>> >>  endif
>> >>
>> >>  ifdef HAVE_CROSS_COMPILE
>> >> @@ -406,7 +410,11 @@ distclean: clean
>> >>         $(RM) config.mak
>> >>         unlink Makefile
>> >>
>> >> +ifdef CONTRIB_DIR
>> >>
>> >+PREBUILT_URL=https://nightlies.videolan.org/build/$(CONTRIB_DIR)/last/vlc-contrib-$(HOST)-$(DATE).tar.bz2
>> >> +else
>> >>
>> >PREBUILT_URL=ftp://ftp.videolan.org/pub/videolan/contrib/$(HOST)/vlc-contrib-$(HOST)-latest.tar.bz2
>> >> +endif
>> >>
>> >>  vlc-contrib-$(HOST)-latest.tar.bz2:
>> >>         $(call download,$(PREBUILT_URL))
>> >> --
>> >> 2.8.2
>> >>
>> >_______________________________________________
>> >vlc-devel mailing list
>> >To unsubscribe or modify your subscription options:
>> >https://mailman.videolan.org/listinfo/vlc-devel
>>
>> For legal (licensing) reasons, this seems like a very bad idea.
>> --
>> Rémi Denis-Courmont
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> In my experience there's way too much that can go wrong by using
> prebuilt contribs.
> If we were to do this, we need to explicitely state which gcc/threading
> model/exception model we support, which mean we leave a whole lot
> behind.
> I'm not sure I'm in favor of the prebuilt model at all to be honest.

I know but that's currently the only way to build a usable VLC on win32.

> Regards,
>
> --
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel