[vlc-devel] [PATCH] contrib: use the nightly builds as prebuilt on Windows

[Steve Lhomme]

On Mon, Jun 12, 2017 at 9:29 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le maanantaina 12. kesäkuuta 2017, 10.20.24 EEST Steve Lhomme a écrit :
>> On Mon, Jun 12, 2017 at 10:09 AM, Rémi Denis-Courmont <remi at remlab.net>
> wrote:
>> > On June 12, 2017 11:04:23 AM GMT+03:00, Steve Lhomme <robux4 at gmail.com>
> wrote:
>> >>Up ?
>> >>They are way more up to date than the old prebuilt which are unusable
>> >>right now. It also makes it easier to update when there are changes in
>> >>the master. Given I never managed to update all the contribs on
>> >>mingw32. I always have to rely on parts of the prebuilt.
>> >>
>> >>On Wed, Oct 26, 2016 at 5:42 PM, Steve Lhomme <robux4 at videolabs.io>
>> >>
>> >>wrote:
>> >>> ---
>> >>>
>> >>>  contrib/src/main.mak | 8 ++++++++
>> >>>  1 file changed, 8 insertions(+)
>> >>>
>> >>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> >>> index da3eebf..d5c3668 100644
>> >>> --- a/contrib/src/main.mak
>> >>> +++ b/contrib/src/main.mak
>> >>> @@ -42,6 +42,10 @@ ARCH := $(shell $(SRC)/get-arch.sh $(HOST))
>> >>>
>> >>>  ifeq ($(ARCH)-$(HAVE_WIN32),x86_64-1)
>> >>>  HAVE_WIN64 := 1
>> >>>
>> >>> +CONTRIB_DIR := win64
>> >>> +endif
>> >>> +ifeq ($(ARCH)-$(HAVE_WIN32),i386-1)
>> >>> +CONTRIB_DIR := win32
>> >>>
>> >>>  endif
>> >>>
>> >>>  ifdef HAVE_CROSS_COMPILE
>> >>>
>> >>> @@ -406,7 +410,11 @@ distclean: clean
>> >>>
>> >>>         $(RM) config.mak
>> >>>         unlink Makefile
>> >>>
>> >>> +ifdef CONTRIB_DIR
>> >>
>> >>+PREBUILT_URL=https://nightlies.videolan.org/build/$(CONTRIB_DIR)/last/vlc
>> >>-contrib-$(HOST)-$(DATE).tar.bz2>>
>> >>> +else
>> >>
>> >>PREBUILT_URL=ftp://ftp.videolan.org/pub/videolan/contrib/$(HOST)/vlc-contr
>> >>ib-$(HOST)-latest.tar.bz2>>
>> >>> +endif
>> >>>
>> >>>  vlc-contrib-$(HOST)-latest.tar.bz2:
>> >>>         $(call download,$(PREBUILT_URL))
>> >>>
>> >>> --
>> >>> 2.8.2
>> >>
>> >>_______________________________________________
>> >>vlc-devel mailing list
>> >>To unsubscribe or modify your subscription options:
>> >>https://mailman.videolan.org/listinfo/vlc-devel
>> >>
>> > For legal (licensing) reasons, this seems like a very bad idea.
>>
>> Why ? They provide the same libraries in the same format. They are
>> also provided by videolan servers.
>
> How do you meet the (L)GPL requirements?

I still fail to see how it changes with a different VideoLAN URL.

> And at a technical level:
>
> How do you ensure that the URL is valid for any given date in the future?

You don't, that's one drawback that I encountered a few times. But it
should be easy to fallback to the old URL in case of failure. We
already have fallback in place for contrib sources.

> How do you differentiate different VLC branches with differing requirements?

I don't understand. The prebuilt help you get started quickly or
wasting time compiling things that are already available. If locally
you need different things, you can.

> How do you deal with days when the contribs build fails?
>
> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel