[vlc-devel] [PATCH 1/2] win32: Add a vlc_mta_holder

[Hugo Beauzée-Luyssen]

On Tue, Jun 13, 2017, at 05:59 PM, Rémi Denis-Courmont wrote:
> Le tiistaina 13. kesäkuuta 2017, 11.50.54 EEST Hugo Beauzée-Luyssen a
> écrit :
> > > Same condvar problem as the background meta worker, which was merged
> > > buggy.
> > 
> > Could you clarify the race/issue here? I must say I don't see it.
> 
> In theory, the child thread can wake itself up, and the parent lock dead. 
> However, it should not be possible with the _current_ implementation of
> VLC 
> ondition variables on Windows.
> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 

Hi,

To be honest, I really don't see it. I trust you regarding the fact that
there is a potential race, but I can't figure out where/how.
I'd be very interested in more details!

And in any case, I just sent a version using a semaphore instead of the
same wait cond.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr