[vlc-devel] [PATCH 2/6] direct3d11: make sur we have a picture->context with D3D11 opaque input

[Hugo Beauzée-Luyssen]

On Wed, Jun 14, 2017, at 03:48 PM, Steve Lhomme wrote:
> CID #1444697
> ---
>  modules/video_output/win32/direct3d11.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules/video_output/win32/direct3d11.c
> b/modules/video_output/win32/direct3d11.c
> index cc6e5aa734..bad58a56d6 100644
> --- a/modules/video_output/win32/direct3d11.c
> +++ b/modules/video_output/win32/direct3d11.c
> @@ -1132,6 +1132,7 @@ static void Prepare(vout_display_t *vd, picture_t
> *picture, subpicture_t *subpic
>      else
>      {
>          /* copy pixels from the context texture to the picture_sys
>          texture */
> +        assert(pic_ctx!=NULL);
>          D3D11_TEXTURE2D_DESC texDesc;
>          ID3D11Texture2D_GetDesc(p_sys->texture[0], &texDesc);
>          if (texDesc.BindFlags & D3D11_BIND_SHADER_RESOURCE)
> -- 
> 2.12.1
> 

The change seems correct but I'm not sure it will be enough for coverity
to mark the defect as fixed, in any case, could you comment on the
defect itself so we know it's actually not a bug?

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr