[vlc-devel] [PATCH 01/19] contrib: fix autoreconf on some packages

[Steve Lhomme]

On Wed, Jun 14, 2017 at 3:34 PM, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
> On Wed, Jun 14, 2017, at 02:01 PM, Steve Lhomme wrote:
>> libmad doesn't build on mingw32 without this
>> ---
>>  contrib/src/main.mak | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 9f49f266ed..7a77d03afb 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -354,8 +354,12 @@ UPDATE_AUTOCONFIG = for dir in
>> $(AUTOMAKE_DATA_DIRS); do \
>>  ifdef HAVE_IOS
>>  AUTORECONF = AUTOPOINT=true autoreconf
>>  else
>> +ifdef HAVE_WIN32
>> +AUTORECONF = rm -rf aclocal.m4 Makefile.in && autoreconf
>> +else
>>  AUTORECONF = autoreconf
>>  endif
>> +endif
>>  RECONF = mkdir -p -- $(PREFIX)/share/aclocal && \
>>       cd $< && $(AUTORECONF) -fiv $(ACLOCAL_AMFLAGS)
>>  CMAKE = cmake . -DCMAKE_TOOLCHAIN_FILE=$(abspath toolchain.cmake) \
>> --
>> 2.12.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> I'd agree this seems dubious, can't this be fixed by fixing the
> bootstrap script (or equivalent) in libmad? Or in anycase, what's the
> error/what happens there without this patch?

This is the error it gives:

autoreconf: running: aclocal -I
/c/Users/robUx4/Documents/Programs/Videolabs/work/contrib/x86_64-w64-mingw32/share/aclocal
--force
aclocal: macro `_LT_COMPILER_PIC' required but not defined
aclocal: macro `_LT_DECL_SED' required but not defined
aclocal: macro `_LT_DECL_SED' required but not defined
aclocal: macro `_LT_FUNC_STRIPNAME_CNF' required but not defined
autoreconf: aclocal failed with exit status: 1

They all come from libtool, so via AC_PROG_LIBTOOL but it's using the
one from an outdated aclocal.m4 (1.8.2)

We could just call "rm -rf aclocal.m4" for libmad after it's extracted+patched.

> --
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel