[vlc-devel] [PATCH 05/19] contrib: caca: build without ncurses on Windows

[Steve Lhomme]

As the comment in the .mak suggests, libcaca can be compiled with an
old version of ncurses. Newer ones or ones compiled without backward
compatibility set NCURSES_MOUSE_VERSION to 2. Resulting in a bunch of
defines that libcaca uses, like BUTTON1_RESERVED_EVENT, missing. I
don't think it's possible to know with pkgconfig if the ncurses
version is compatible.
Another way to do this would be to fix the ncurses detection in the
libcaca configure script.

On Wed, Jun 14, 2017 at 3:43 PM, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
> On Wed, Jun 14, 2017, at 02:01 PM, Steve Lhomme wrote:
>> libcaca cannot handle the ncurses (and signal) version from mingw
>> It's also not built in the the buildbot
>> ---
>>  contrib/src/caca/rules.mak | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/contrib/src/caca/rules.mak b/contrib/src/caca/rules.mak
>> index 95e3325a08..b04c3f3a8f 100644
>> --- a/contrib/src/caca/rules.mak
>> +++ b/contrib/src/caca/rules.mak
>> @@ -32,6 +32,10 @@ CACA_CONF := \
>>  ifdef HAVE_MACOSX
>>  CACA_CONF += --disable-x11
>>  endif
>> +ifdef HAVE_WIN32
>> +#caca is only compatible with old ncurses that have
>> NCURSES_MOUSE_VERSION set to 1
>> +CACA_CONF += --disable-ncurses
>> +endif
>>
>>  .caca: caca
>>       cd $< && $(HOSTVARS) ./configure $(HOSTCONF) $(CACA_CONF)
>> --
>> 2.12.1
>>
>
> I'd tend to ask a comment clarification regarding the fact that
> libcaca's check for (n)curses.h is incomplete and leads to a false
> positive when building natively from msys2, otherwise LGTM
>
> --
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel