[vlc-devel] [PATCH 1/2] configure: allow toggling of -Wl, -z, defs and -no-undefined

[Hugo Beauzée-Luyssen]

On Mon, Jun 19, 2017, at 04:55 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 19. kesäkuuta 2017, 15.54.11 EEST Hugo Beauzée-Luyssen a 
> écrit :
> > > >I'm having a similar issue with thread sanitizer, and would really like
> > > >to know how to build correctly without the mentioned flags.
> > > >
> > > >Regards,
> > 
> > Would you ming sharing the settings/flags you use to run TSAN then?
> 
> Oh, tsan? I have not tried that one, though I don´t see why it would be
> any 
> different than asan. The mail thread was about asan.
> 
> (However, I would be surprised if it lead to workable results with VLC;
> at 
> least Helgrind did not.)
> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

I have no issue with ASAN, however it seems your mileage may vary on
macOS. On linux I have do basically what this patch does to have the
various libs built without error, otherwise it just spills a few hundred
lines of link errors. UBSAN has no issue.

I don't think the intention of this patch is to plainly disable
no-undefined, but rather to allow someone to do it if required (which
appears to be the case for ASAN on macOS, and TSAN on linux). Or we
could consider another option that was mentioned, ie. disabling
no-undefined based on a per-sanitizer flag.
However I completely agree that no-undefined should not be set in most
cases.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr