[vlc-devel] [PATCH 18/23] directx_va: move the pre-allocated hw_surface in directx_va
Steve Lhomme
robux4 at videolabs.io
Wed Jun 21 14:15:03 CEST 2017
---
modules/codec/avcodec/d3d11va.c | 22 ++++++++++++----------
modules/codec/avcodec/directx_va.h | 3 +++
modules/codec/avcodec/dxva2.c | 18 +++++++++---------
modules/codec/avcodec/va_surface.c | 4 +---
modules/codec/avcodec/va_surface_internal.h | 3 +--
5 files changed, 26 insertions(+), 24 deletions(-)
diff --git a/modules/codec/avcodec/d3d11va.c b/modules/codec/avcodec/d3d11va.c
index 6a25975548..4f23e3f2f1 100644
--- a/modules/codec/avcodec/d3d11va.c
+++ b/modules/codec/avcodec/d3d11va.c
@@ -166,7 +166,7 @@ void SetupAVCodecContext(vlc_va_t *va)
sys->hw.decoder = dx_sys->decoder;
sys->hw.cfg = &sys->cfg;
sys->hw.surface_count = dx_sys->va_pool.surface_count;
- sys->hw.surface = dx_sys->va_pool.hw_surface;
+ sys->hw.surface = dx_sys->hw_surface;
sys->hw.context_mutex = sys->context_mutex;
if (IsEqualGUID(&dx_sys->input, &DXVA_Intel_H264_NoFGT_ClearVideo))
@@ -239,8 +239,10 @@ done:
return pic_ctx;
}
-static struct va_pic_context* NewSurfacePicContext(vlc_va_t *va, ID3D11VideoDecoderOutputView *surface)
+static struct va_pic_context* NewSurfacePicContext(vlc_va_t *va, int surface_index)
{
+ directx_sys_t *dx_sys = &va->sys->dx_sys;
+ ID3D11VideoDecoderOutputView *surface = dx_sys->hw_surface[surface_index];
ID3D11ShaderResourceView *resourceView[D3D11_MAX_SHADER_VIEW];
ID3D11Resource *p_resource;
ID3D11VideoDecoderOutputView_GetResource(surface, &p_resource);
@@ -792,7 +794,7 @@ static int DxCreateDecoderSurfaces(vlc_va_t *va, int codec_id,
for (surface_idx = 0; surface_idx < surface_count; surface_idx++) {
picture_t *pic = decoder_NewPicture( (decoder_t*) va->obj.parent );
sys->extern_pics[surface_idx] = pic;
- dx_sys->va_pool.hw_surface[surface_idx] = NULL;
+ dx_sys->hw_surface[surface_idx] = NULL;
if (pic==NULL)
{
msg_Warn(va, "not enough decoder pictures %d out of %d", surface_idx, surface_count);
@@ -835,17 +837,17 @@ static int DxCreateDecoderSurfaces(vlc_va_t *va, int codec_id,
AllocateShaderView(VLC_OBJECT(va), dx_sys->d3ddev, textureFmt, pic->p_sys->texture, pic->p_sys->slice_index, pic->p_sys->resourceView);
- dx_sys->va_pool.hw_surface[surface_idx] = pic->p_sys->decoder;
+ dx_sys->hw_surface[surface_idx] = pic->p_sys->decoder;
}
if (!sys->b_extern_pool)
{
for (size_t i = 0; i < surface_idx; ++i)
{
- if (dx_sys->va_pool.hw_surface[i])
+ if (dx_sys->hw_surface[i])
{
- ID3D11VideoDecoderOutputView_Release(dx_sys->va_pool.hw_surface[i]);
- dx_sys->va_pool.hw_surface[i] = NULL;
+ ID3D11VideoDecoderOutputView_Release(dx_sys->hw_surface[i]);
+ dx_sys->hw_surface[i] = NULL;
}
if (sys->extern_pics[i])
{
@@ -893,7 +895,7 @@ static int DxCreateDecoderSurfaces(vlc_va_t *va, int codec_id,
hr = ID3D11VideoDevice_CreateVideoDecoderOutputView( dx_sys->d3ddec,
(ID3D11Resource*) p_texture,
&viewDesc,
- &dx_sys->va_pool.hw_surface[surface_idx] );
+ &dx_sys->hw_surface[surface_idx] );
if (FAILED(hr)) {
msg_Err(va, "CreateVideoDecoderOutputView %d failed. (hr=0x%0lx)", surface_idx, hr);
ID3D11Texture2D_Release(p_texture);
@@ -986,13 +988,13 @@ static void DxDestroySurfaces(vlc_va_t *va)
directx_sys_t *dx_sys = &va->sys->dx_sys;
if (dx_sys->va_pool.surface_count && !va->sys->b_extern_pool) {
ID3D11Resource *p_texture;
- ID3D11VideoDecoderOutputView_GetResource( dx_sys->va_pool.hw_surface[0], &p_texture );
+ ID3D11VideoDecoderOutputView_GetResource( dx_sys->hw_surface[0], &p_texture );
ID3D11Resource_Release(p_texture);
ID3D11Resource_Release(p_texture);
}
for (unsigned i = 0; i < dx_sys->va_pool.surface_count; i++)
{
- ID3D11VideoDecoderOutputView_Release( dx_sys->va_pool.hw_surface[i] );
+ ID3D11VideoDecoderOutputView_Release( dx_sys->hw_surface[i] );
for (int j = 0; j < D3D11_MAX_SHADER_VIEW; j++)
{
if (va->sys->resourceView[i*D3D11_MAX_SHADER_VIEW + j])
diff --git a/modules/codec/avcodec/directx_va.h b/modules/codec/avcodec/directx_va.h
index 4aa872f3ce..1e6155b8fd 100644
--- a/modules/codec/avcodec/directx_va.h
+++ b/modules/codec/avcodec/directx_va.h
@@ -55,6 +55,9 @@ typedef struct
{
va_pool_t va_pool;
+ /* for pre allocation */
+ D3D_DecoderSurface *hw_surface[MAX_SURFACE_COUNT];
+
/* DLL */
HINSTANCE hdecoder_dll;
const TCHAR *psz_decoder_dll;
diff --git a/modules/codec/avcodec/dxva2.c b/modules/codec/avcodec/dxva2.c
index 5b002ed752..768953ae83 100644
--- a/modules/codec/avcodec/dxva2.c
+++ b/modules/codec/avcodec/dxva2.c
@@ -168,7 +168,7 @@ void SetupAVCodecContext(vlc_va_t *va)
sys->hw.decoder = dx_sys->decoder;
sys->hw.cfg = &sys->cfg;
sys->hw.surface_count = dx_sys->va_pool.surface_count;
- sys->hw.surface = dx_sys->va_pool.hw_surface;
+ sys->hw.surface = dx_sys->hw_surface;
if (IsEqualGUID(&dx_sys->input, &DXVA_Intel_H264_NoFGT_ClearVideo))
sys->hw.workaround |= FF_DXVA2_WORKAROUND_INTEL_CLEARVIDEO;
@@ -218,10 +218,10 @@ static struct va_pic_context *CreatePicContext(IDirect3DSurface9 *surface)
return pic_ctx;
}
-static struct va_pic_context* NewSurfacePicContext(vlc_va_t *va, IDirect3DSurface9 *surface)
+static struct va_pic_context* NewSurfacePicContext(vlc_va_t *va, int surface_index)
{
- VLC_UNUSED(va);
- return CreatePicContext(surface);
+ directx_sys_t *dx_sys = &va->sys->dx_sys;
+ return CreatePicContext(dx_sys->hw_surface[surface_index]);
}
static int Get(vlc_va_t *va, picture_t *pic, uint8_t **data)
@@ -663,7 +663,7 @@ static int DxCreateVideoDecoder(vlc_va_t *va, int codec_id,
D3DPOOL_DEFAULT,
0,
DXVA2_VideoDecoderRenderTarget,
- sys->va_pool.hw_surface,
+ sys->hw_surface,
NULL);
if (FAILED(hr)) {
msg_Err(va, "IDirectXVideoAccelerationService_CreateSurface %d failed (hr=0x%0lx)", surface_count - 1, hr);
@@ -686,7 +686,7 @@ static int DxCreateVideoDecoder(vlc_va_t *va, int codec_id,
if (FAILED(hr)) {
msg_Err(va, "extra buffer impossible, avoid a crash (hr=0x%0lx)", hr);
for (unsigned i = 0; i < surface_count; i++)
- IDirect3DSurface9_Release( sys->va_pool.hw_surface[i] );
+ IDirect3DSurface9_Release( sys->hw_surface[i] );
return VLC_EGENERIC;
}
IDirect3DSurface9_Release(tstCrash);
@@ -729,7 +729,7 @@ static int DxCreateVideoDecoder(vlc_va_t *va, int codec_id,
&cfg_list))) {
msg_Err(va, "IDirectXVideoDecoderService_GetDecoderConfigurations failed");
for (unsigned i = 0; i < surface_count; i++)
- IDirect3DSurface9_Release( sys->va_pool.hw_surface[i] );
+ IDirect3DSurface9_Release( sys->hw_surface[i] );
return VLC_EGENERIC;
}
msg_Dbg(va, "we got %d decoder configurations", cfg_count);
@@ -771,12 +771,12 @@ static int DxCreateVideoDecoder(vlc_va_t *va, int codec_id,
&sys->input,
&dsc,
&p_sys->cfg,
- sys->va_pool.hw_surface,
+ sys->hw_surface,
surface_count,
&decoder))) {
msg_Err(va, "IDirectXVideoDecoderService_CreateVideoDecoder failed");
for (unsigned i = 0; i < surface_count; i++)
- IDirect3DSurface9_Release( sys->va_pool.hw_surface[i] );
+ IDirect3DSurface9_Release( sys->hw_surface[i] );
return VLC_EGENERIC;
}
sys->decoder = decoder;
diff --git a/modules/codec/avcodec/va_surface.c b/modules/codec/avcodec/va_surface.c
index 5bd7176f92..1f2eab0f69 100644
--- a/modules/codec/avcodec/va_surface.c
+++ b/modules/codec/avcodec/va_surface.c
@@ -34,8 +34,6 @@
#include <vlc_codec.h>
#include <vlc_picture.h>
-
-#define D3D_DecoderSurface void
struct picture_sys_t {
void *dummy;
};
@@ -98,7 +96,7 @@ int va_pool_Setup(vlc_va_t *va, va_pool_t *va_pool, const AVCodecContext *avctx,
struct vlc_va_surface_t *p_surface = malloc(sizeof(*p_surface));
if (unlikely(p_surface==NULL))
goto done;
- va_pool->surface[i] = va_pool->pf_new_surface_context(va, va_pool->hw_surface[i]);
+ va_pool->surface[i] = va_pool->pf_new_surface_context(va, i);
if (unlikely(va_pool->surface[i]==NULL))
{
free(p_surface);
diff --git a/modules/codec/avcodec/va_surface_internal.h b/modules/codec/avcodec/va_surface_internal.h
index 8bfd96f8a4..da2dc4b745 100644
--- a/modules/codec/avcodec/va_surface_internal.h
+++ b/modules/codec/avcodec/va_surface_internal.h
@@ -48,7 +48,6 @@ typedef struct
int surface_height;
struct va_pic_context *surface[MAX_SURFACE_COUNT];
- D3D_DecoderSurface *hw_surface[MAX_SURFACE_COUNT];
int (*pf_create_device)(vlc_va_t *);
void (*pf_destroy_device)(vlc_va_t *);
@@ -77,7 +76,7 @@ typedef struct
/**
* Create a new context for the surface being acquired
*/
- struct va_pic_context* (*pf_new_surface_context)(vlc_va_t *, D3D_DecoderSurface *);
+ struct va_pic_context* (*pf_new_surface_context)(vlc_va_t *, int surface_index);
} va_pool_t;
--
2.12.1
More information about the vlc-devel
mailing list