[vlc-devel] [PATCH] variables: correct minimum float value

[Thomas Guillem]

LGTM

On Wed, Jun 21, 2017, at 16:12, Victorien Le Couviour--Tuffet wrote:
> FLT_MIN is the minimum normalized positive floating-point value not the
> minimum
> negative value a float can contain. This is very different.
> This fixes the issue with the adjust's hue variable, which has a range of
> [-180;180]. When the variable was set lower than 0, it was clipped back
> to
> zero.
> ---
>  src/misc/variables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/misc/variables.c b/src/misc/variables.c
> index 610e414593..d441684c06 100644
> --- a/src/misc/variables.c
> +++ b/src/misc/variables.c
> @@ -340,7 +340,7 @@ int var_Create( vlc_object_t *p_this, const char
> *psz_name, int i_type )
>          case VLC_VAR_FLOAT:
>              p_var->ops = &float_ops;
>              p_var->val.f_float = 0.f;
> -            p_var->min.f_float = FLT_MIN;
> +            p_var->min.f_float = -FLT_MAX;
>              p_var->max.f_float = FLT_MAX;
>              break;
>          case VLC_VAR_COORDS:
> -- 
> 2.13.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel