[vlc-devel] [PATCH] stream: iconv: convert only if we have a conversion descriptor

[Rémi Denis-Courmont]

Le 22 juin 2017 14:44:49 GMT+03:00, Shaleen Jain <shaleen.jain95 at gmail.com> a écrit :
>
>On Wed, Jun 21, 2017 at 11:38 PM, Rémi Denis-Courmont 
><remi at remlab.net> wrote:
>> Le keskiviikkona 21. kesäkuuta 2017, 22.55.37 EEST Shaleen Jain a 
>> écrit :
>>>  How so?
>> 
>> It´s still not resulting in anything sane.
>I'm sorry I don't see how the logic is incorrect,
>if priv->text.conv is -1 (which will happen if vlc_iconv_open() fails)
>priv->text.conv != (vlc_iconv_t)(-1) would be false and vlc_iconv() 
>would not run, otherwise it would proceed to do the conversion.
>> 
>> 
>> --
>> 雷米‧德尼-库尔蒙
>> https://www.remlab.net/
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

Skipping the conversion is not going to result in sane behaviour.
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170622/97a18b95/attachment.html>