[vlc-devel] [PATCH 2/2] macOS: Don't draw custom VLCHUDCheckboxCell on 10.10+

[David Fuhrmann]

> Am 21.06.2017 um 02:09 schrieb Marvin Scholz <epirat07 at gmail.com>:
> 
> ---
> modules/gui/macosx/VLCHUDCheckboxCell.m | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> 
> diff --git a/modules/gui/macosx/VLCHUDCheckboxCell.m b/modules/gui/macosx/VLCHUDCheckboxCell.m
> index 93df527d3a..341d4c1c74 100644
> --- a/modules/gui/macosx/VLCHUDCheckboxCell.m
> +++ b/modules/gui/macosx/VLCHUDCheckboxCell.m
> @@ -33,9 +33,19 @@
> //	POSSIBILITY OF SUCH DAMAGE.
> 
> #import "VLCHUDCheckboxCell.h"
> +#import "CompatibilityFixes.h"
> 
> @implementation VLCHUDCheckboxCell
> 
> ++ (void)load
> +{
> +    if (OSX_YOSEMITE_AND_HIGHER) {
> +        swapoutOverride([VLCHUDCheckboxCell class], @selector(initWithCoder:));
> +        swapoutOverride([VLCHUDCheckboxCell class], @selector(drawImage:withFrame:inView:));
> +        swapoutOverride([VLCHUDCheckboxCell class], @selector(drawTitle:withFrame:inView:));
> +    }
> +}
> +

Hi,

Ok, but can you add a small comment why you can’t call super? It might be not obvious later…

BR. David