[vlc-devel] [PATCH] transform: change var_InheritString to var_CreateGetStringCommand

[Thomas Guillem]

On Fri, Jun 23, 2017, at 08:49, Victorien Le Couviour--Tuffet wrote:
> ---
>  modules/video_filter/transform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/video_filter/transform.c
> b/modules/video_filter/transform.c
> index 7c88f234ef..9065cdad9f 100644
> --- a/modules/video_filter/transform.c
> +++ b/modules/video_filter/transform.c
> @@ -324,7 +324,7 @@ static int Open(vlc_object_t *object)
>  
>      config_ChainParse(filter, CFG_PREFIX, ppsz_filter_options,
>                        filter->p_cfg);
> -    char *type_name = var_InheritString(filter, CFG_PREFIX"type");
> +    char *type_name = var_CreateGetStringCommand(filter,
> CFG_PREFIX"type");

If I understand the code (since COMMAND vars are not well documented), a
variable should be a command only if there is a callback, so only if the
module can handle a change of value.

This is not the case here.

>      const transform_description_t *dsc = NULL;
>  
>      for (size_t i = 0; i < n_transforms; i++)
> -- 
> 2.13.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel