[vlc-devel] [PATCH] vaapi: refactor display handling

[Mathieu Velten]

2017-06-28 22:10 GMT+02:00 Rémi Denis-Courmont <remi at remlab.net>:
> Le keskiviikkona 28. kesäkuuta 2017, 20.06.31 EEST Mathieu Velten a écrit
:
>> Le mer. 28 juin 2017 à 21:47, Rémi Denis-Courmont <remi at remlab.net> a
>>
>> écrit :
>> > Le keskiviikkona 28. kesäkuuta 2017, 21.22.06 EEST Mathieu Velten a
écrit
> :
>> > > The code to initiate the VADisplay has been moved in hw/vaapi.
>> > > You can use --vaapi-display-type to force a type of display.
>> >
>> > The display type is normally chosen by the vout window provider; the
>> > semantics
>> > of that option do not seem to make much sense.
>> >
>> > Also the VA-DRM module shall not depend on X11. This patch is a
>> > regression.
>> >
>> > Nack.
>>
>> Then what do you think about:
>> - removing the code regarding VADisplay initialisation from the init of
the
>> gl vaapi converter
>> - fetch it later just before the first conversion through the existing
>> instance singleton
>
> Your design is already broken to start with if you assume the VA instance
is a
> singleton.

Is it not the current design ?
Currently for DR the VADisplay is shared between the vout and the decoder
through something looking a lot like a singleton (instance.c). I am bad at
C so I could be wrong.

>
> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170628/163d269d/attachment.html>