[vlc-devel] [PATCH] remove X11BypassWindowManagerHint from time tooltip

Ludovic Fauvet etix at videolan.org
Wed Jun 28 23:48:26 CEST 2017


I can confirm it works on the latest release of KDE. AFAIR I added the
X11BypassWindowManagerHint option because of a regression in KDE which
lasted for quite some time.

If it works on Windows too, I'm in favor of pushing the change.
-- 
Ludovic Fauvet
www.videolan.org


On Wed, Jun 28, 2017, at 23:16, Jean-Baptiste Kempf wrote:
> Hello,
> 
> This is partly reverting
> https://git.videolan.org/?p=vlc.git;a=commit;h=dd601fe869a0e3f3cbfc8a609b197d49d4ce9c5c
> 
> Are you sure this is correct? Is this tested on KDE? Did you ask Ludo?
> 
> best,
> 
> On Wed, 28 Jun 2017, at 21:29, Mathieu Velten wrote:
> > Fixes #17829
> > ---
> >  modules/gui/qt/util/timetooltip.cpp | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/modules/gui/qt/util/timetooltip.cpp
> > b/modules/gui/qt/util/timetooltip.cpp
> > index 9afb30ca9e..0657210f1a 100644
> > --- a/modules/gui/qt/util/timetooltip.cpp
> > +++ b/modules/gui/qt/util/timetooltip.cpp
> > @@ -35,8 +35,7 @@ TimeTooltip::TimeTooltip( QWidget *parent ) :
> >  {
> >      setWindowFlags( Qt::Tool                    |
> >                      Qt::WindowStaysOnTopHint    |
> > -                    Qt::FramelessWindowHint     |
> > -                    Qt::X11BypassWindowManagerHint );
> > +                    Qt::FramelessWindowHint     );
> >  
> >      // Tell Qt that it doesn't need to erase the background before
> >      // a paintEvent occurs. This should save some CPU cycles.
> > -- 
> > 2.13.0
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> 
> 
> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list