[vlc-devel] [PATCH] vaapi: refactor display handling

Thomas Guillem thomas at gllm.fr
Thu Jun 29 08:58:02 CEST 2017

On Wed, Jun 28, 2017, at 22:58, Rémi Denis-Courmont wrote:
> Le keskiviikkona 28. kesäkuuta 2017, 20.17.59 EEST Mathieu Velten a écrit
> :
> > Is it not the current design ?

Yes it's a singleton. It's kind of a bad design, but I don't see how to
do it differently with 3.0 core apis.

> I don´t know. The current design was not sent for review so I have not
> looked 
> at it. What I do know is that it broke DRM, even though this issue was
> raised 
> in previous reviews.

And I fixed vaapi-x11/drm according to the review. I thought I fixed it,
but I didn't see a problem during my tests: If the vout is GL, it'll try
to create the vaapi instance, therefore, vlc_va_t modules won't be able
to create a X11/DRM vaapi one. There is no problem on desktops that
doesn't handle interop or if you disable gl.
Sadly, I tested vlc_va_t vaapi-x11/drm on a desktop that doesn't handle
vaapi interop (nvidia card), therefore I was able to use it. That's why
I didn't see the issue.

To fix (or workaround) this issue, I thought of adding DRM support in
the vaapi gl converter, so either you have DRM with direct rendering via
the vout, or you have DRM with software rendering via vlc_va_t.

> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list