[vlc-devel] [PATCH 02/23] macosx: helpers: add getVouts

[Victorien Le Couviour--Tuffet]

On Thu, Jun 29, 2017 at 02:46:20PM +0200, Marvin Scholz wrote:
> Thanks for your patches.
>

You're welcome.

> On 29 Jun 2017, at 14:24, Victorien Le Couviour--Tuffet wrote:
> 
> > +static inline NSArray<NSValue *> *getVouts(void)
> 
> I don't think we can use type annotated arrays yet, given that VLC still
> needs to build with
> old Xcode versions, for now.

What is the version you have in mind? I'm compiling with the default value of
--with-macosx-version-min which is 10.7.

> > +
> > +    for (size_t i = 0; i < i_num_vouts; ++i)
> > +    {
> > +        assert(pp_vouts[i]);
> > +        [vouts insertObject : [NSValue valueWithPointer : pp_vouts[i]]
> > // try addObject
> 
> What does the "try addObject" comment means?

It was just a comment for myself I forgot to remove, I answered myself with a
patch without it.

I'll send new patches with changes for the other comments.