[vlc-devel] [PATCH 02/23] macosx: helpers: add getVouts

[Victorien Le Couviour--Tuffet]

On Thu, Jun 29, 2017 at 02:46:20PM +0200, Marvin Scholz wrote:
> On 29 Jun 2017, at 14:24, Victorien Le Couviour--Tuffet wrote:
> 
> It would be awesome if you could add a doxygen-style comment.
> 
> > +    if (!p_input
> > +        || input_Control(p_input, INPUT_GET_VOUTS, &pp_vouts,
> > &i_num_vouts)
> > +        || !i_num_vouts)
> > +        return [NSArray array];
> 
> Wouldn't it make more sense to return nil here?
> 
> > +
> > +    NSMutableArray<NSValue *> *vouts =
> > +        [NSMutableArray arrayWithCapacity : i_num_vouts];
> 
> Minor codestyle thing: I prefer to not put a space before and after the ":",
> this
> is a very uncommon thing to do in Objective C.
> 
> NSMutableArray<NSValue *> *vouts = [NSMutableArray
> arrayWithCapacity:i_num_vouts];
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-macosx-helpers-add-getVouts.patch
Type: text/x-diff
Size: 1538 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170629/da6b5754/attachment.patch>