[vlc-devel] [PATCH 4/4] chromecast: Ensure the demux gets unblocked

[Hugo Beauzée-Luyssen]

On Thu, Mar 2, 2017, at 10:46 AM, Hugo Beauzée-Luyssen wrote:
> ...when waiting for the application to start
> ---
>  modules/stream_out/chromecast/chromecast_ctrl.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules/stream_out/chromecast/chromecast_ctrl.cpp
> b/modules/stream_out/chromecast/chromecast_ctrl.cpp
> index 94bf6f7dc7..ac16360eca 100644
> --- a/modules/stream_out/chromecast/chromecast_ctrl.cpp
> +++ b/modules/stream_out/chromecast/chromecast_ctrl.cpp
> @@ -148,6 +148,7 @@ intf_sys_t::~intf_sys_t()
>      vlc_interrupt_destroy( m_ctl_thread_interrupt );
>  
>      // make sure we unblock the demuxer
> +    setState( Dead );
>      m_seek_request_time = VLC_TS_INVALID;
>      vlc_cond_signal(&m_seekCommandCond);
>  
> -- 
> 2.11.0
> 

Please disregard this patch, the wait cond is destroyed a couple lines
later, this can't be right.
My opinion is that the wait cond *must* not be signaled from the
destructor, but rather when we are signaling a stop, but the chromecast
teardown sequence is still a bit blury to me.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr