[vlc-devel] [PATCH 0/3] access/satip: minor fixes

Filip Roséen filip at atch.se
Thu Mar 2 19:37:34 CET 2017

These patches are a follow-up to the discussion between me and Rémi
Denis-Cournmount linked below:

 - https://mailman.videolan.org/pipermail/vlc-devel/2017-March/111861.html

The changes are as minor as possible in order to not disturb the delicate
entity which the satip accessor is. One might for example ask why the
return-value of `vlc_UrlParse` is not checked, instead of checking the
individual attributes by themselves; and the reason is.. satip.

To quote Jean-Baptist Kempf:

    19:00:51 j-b: be EXTRA careful
    19:01:27 j-b: Satip is not conforming to any spec
    19:01:31 j-b: including URL spec

The changes in this patch-batch are as minor as impossible in order to not
break any existing usage of the module. The changes goal is to make the module
more robust, and prevent it from crashing on unexpected data, while not
disturbing it too much (perhaps leading to regressions).

Filip Roséen (3):
  access/satip: fix null-dereference on missing host
  access/satip: fix null-dereference on "malformed" protocol
  access/satip: check return-value of vlc_uri_compose

 modules/access/satip.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


More information about the vlc-devel mailing list