[vlc-devel] [PATCH 1/3] access/satip: fix null-dereference on missing host

Filip Roséen filip at atch.se
Thu Mar 2 20:15:33 CET 2017


Hi j-b,

On 2017-03-02 20:02, Jean-Baptiste Kempf wrote:

> Hello,
> 
> On Thu, 2 Mar 2017, at 19:37, Filip Roséen wrote:
> > The module assumes that the vlc_url_t populated by vlc_UrlParse always
> > have an entry in vlc_url_t::psz_host, which is not the case for
> > something such as "satip://:80".
> 
> Sure, but I'd argue we should fail earlier then.
> This protocol is broken, we should only support very-narrow cases.

See attached patch for early abort instead of using --satip-host as
fallback.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170302/0161d871/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-access-satip-fix-null-dereference-on-missing-host.patch
Type: text/x-diff
Size: 3001 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170302/0161d871/attachment.patch>


More information about the vlc-devel mailing list