[vlc-devel] [PATCH] stream_extractor/archive: fix building with old libraries

[Filip Roséen]

Hi Steve,

On 2017-03-03 13:19, Steve Lhomme wrote:

> diff --git a/modules/stream_extractor/archive.c b/modules/stream_extractor/archive.c
> index efdd4e4314..3b5d015b3d 100644
> --- a/modules/stream_extractor/archive.c
> +++ b/modules/stream_extractor/archive.c
> @@ -36,6 +36,11 @@
>  #include <archive.h>
>  #include <archive_entry.h>
>  
> +#ifndef __LA_INT64_T_DEFINED
> +typedef __LA_INT64_T la_int64_t;
> +typedef __LA_SSIZE_T la_ssize_t;
> +#endif

Looks alright to be, but there is a separate define related to
`la_ssize_t`; `__LA_SSIZE_T_DEFINED`. I think the end-result will be
the same since I think that if one of the defines is missing, then
both are.

Have you checked if there's any way of having either of
`__LA_INT64_T_DEFINED` and `__LA_SSIZE_T_DEFINED`, but not both?

>  static  int ExtractorOpen( vlc_object_t* );
>  static void ExtractorClose( vlc_object_t* );
>  

Best Regards,\
Filip Roséen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170303/ba901ee7/attachment.html>