[vlc-devel] [PATCH] stream_extractor/archive: fix building with old libraries

[Filip Roséen]

Hi Steve,

On 2017-03-03 13:39, Steve Lhomme wrote:

> On Fri, Mar 3, 2017 at 1:35 PM, Filip Roséen <filip at atch.se> wrote:
>
> > Looks alright to be, but there is a separate define related to la_ssize_t;
> > __LA_SSIZE_T_DEFINED. I think the end-result will be the same since I think
> > that if one of the defines is missing, then both are.
> >
> > Have you checked if there’s any way of having either of __LA_INT64_T_DEFINED
> > and __LA_SSIZE_T_DEFINED, but not both?
> 
> No, I only checked a way to differentiate between old and new headers.
> They don't even have a version for the API/name changes...

There's `ARCHIVE_VERSION_NUMBER`, which should be stable enough to
make decision based on the *libarchive* version.

In either case, I think the safest bet is to use both of
`__LA_SSIZE_T_DEFINED` and `__LA_INT64_T_DEFINED`, even though I guess
using one (as you did) is probably good enough.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170303/d4b9c8ce/attachment.html>