[vlc-devel] [PATCH 0/2] vout: subtitles outside the video

[Salah-Eddin Shaban]

On Fri, Mar 3, 2017 at 2:43 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> Le 02/03/2017 à 14:32, Salah-Eddin Shaban a écrit :
>>
>> What is it exactly you think might be incompatible?
>>
>> This patch changes only the resolution of the generated subpictures
>> and the dimensions in which they are laid out.
>
> These are not subtitles. If the subpicture was computed for full
> overlay, changing dimensions to have it laid under the picture will be
> incompatible. Probably same for OSD.
>

Why should the dimensions be changed?

If a region has the SUBPICTURE_ALIGN_BOTTOM flag, its i_y field is
interpreted to be the distance from the bottom edge of the video
(vout_subpictures.c:SpuRegionPlace), or in direct3d9/opengl with the
patches applied, the bottom edge of the display.