[vlc-devel] [PATCH 07/15] configure: Enable extended C++11 support

[Hugo Beauzée-Luyssen]

On Wed, Mar 8, 2017, at 05:04 PM, Julian Scheel wrote:
> On 08.03.2017 16:32, Hugo Beauzée-Luyssen wrote:
> > On Wed, Mar 8, 2017, at 03:55 PM, Julian Scheel wrote:
> >> VLC uses posix_memalign, which in newlib is not implemented for strict
> >> ansi builds.
> >>
> >> Signed-off-by: Julian Scheel <julian at jusst.de>
> >> ---
> >>  configure.ac | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index b1cf33cf40..a1980b6e81 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -79,7 +79,7 @@ dnl Check for compiler properties
> >>  AC_C_CONST
> >>  AC_C_INLINE
> >>  AC_C_RESTRICT
> >> -AX_CXX_COMPILE_STDCXX_11(noext, mandatory)
> >> +AX_CXX_COMPILE_STDCXX_11(ext, mandatory)
> >>
> >>  dnl Extend the --help string at the current spot.
> >>  AC_DEFUN([EXTEND_HELP_STRING], [m4_divert_once([HELP_ENABLE], [$1])])
> >> --
> >> 2.12.0
> >>
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> >
> > Hi,
> >
> > Shouldn't configure detect it and use the compat version?
> 
> Hi,
> 
> it's checked with AC_REPLACE_FUNCS. But as we have GNU extensions 
> enabled for the C compiler that check sees posix_memalign. For the C++ 
> compiler GNU extensions were disabled until now, so it did not provide 
> posix_memalign in there.
> This patch just unifies C and C++ build wrt GNU extennsions.
> 

I'm surprised it didn't bit anyone before to be honest.
That being said, I don't mind that patch too much, even though I'd be
more in favor of moving to aligned_alloc instead.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr