[vlc-devel] [PATCH 01/15] newlib/nacl: Provide flockfile implementation

[Julian Scheel]

On 08.03.17 18:12, Rémi Denis-Courmont wrote:
> Le keskiviikkona 8. maaliskuuta 2017, 15.55.18 EET Julian Scheel a écrit :
>> newlib does not provide a flockfile implementation currently. Use the
>> existing compat implementation from win32.
>>
>> Signed-off-by: Julian Scheel <julian at jusst.de>
>> ---
>>  compat/flockfile.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/compat/flockfile.c b/compat/flockfile.c
>> index afe8a3e111..bef83f9895 100644
>> --- a/compat/flockfile.c
>> +++ b/compat/flockfile.c
>> @@ -24,7 +24,7 @@
>>
>>  #include <stdio.h>
>>
>> -#ifdef _WIN32
>> +#if defined(_WIN32) || defined(_NEWLIB_VERSION)
>>  # ifndef HAVE__LOCK_FILE
>>  #  warning Broken SDK: VLC logs will be garbage.
>>  #  define _lock_file(s) ((void)(s))
>
> And newlib supports Win32 locking? Otherwise, this makes no sense.

I don't see anything win32 specific in that implementation. We don't 
have a lock_file implementation in NaCl, so we'll end up with the 
"Broken SDK: VLC logs will be garbage." warning. But I think this is ok 
for here.

-Julian