[vlc-devel] [PATCH 11/15] nacl: Add custom thread implementation
dhamester at jusst.de
Thu Mar 9 12:31:30 CET 2017
On 03/09/2017 11:08 AM, Thomas Guillem wrote:
> On Wed, Mar 8, 2017, at 22:37, Dennis Hamester wrote:
>> On 03/08/2017 06:36 PM, Rémi Denis-Courmont wrote:
>>> Le keskiviikkona 8. maaliskuuta 2017, 16.55.12 EET Hugo Beauzée-Luyssen a
>>> écrit :
>>>> This seems to be mostly whitespaces and removing assertions compared to
>>>> android/thread.c Is there any other difference?
>>> It provides an implementation of VLC futeces, but I can´t fathom what its
>>> point is.
>> Its point is exactly that, implement VLC futexes, which are heavily used
>> in src/misc/thread.c for VLC condition variables.
> Could you use src/android/thread.c for thread cancel and co, and then
> src/nacl/thread.c for vlc_addr_* implementations ?
> Maybe, we can rename src/android/thread.c to something else (like
> src/dumb/thread.c ;))
That would certainly be possible. I know the code duplication is
unfortunate, but I would really like to not touch code for other
platforms in this series.
Maybe we can merge it for now as is, an then afterwards come up with a
proper solution? Does anyone else have an opinion on this?
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> Email had 1 attachment:
>> + signature.asc
>> 1k (application/pgp-signature)
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 862 bytes
Desc: OpenPGP digital signature
More information about the vlc-devel