[vlc-devel] [PATCH 3/3] [RFC] core: win32: use the altered search path to load modules

[Rémi Denis-Courmont]

On March 10, 2017 10:52:32 AM GMT+02:00, Steve Lhomme <robux4 at videolabs.io> wrote:
>The modules are always loaded with an absolute path. And on startup we
>already
>set the DefaultDllDirectories to LOAD_LIBRARY_SEARCH_SYSTEM32. So we
>should not
>need anything else to load modules properly with their system
>libraries.
>---
> src/win32/specific.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/src/win32/specific.c b/src/win32/specific.c
>index a39fae7251..5357d01d15 100644
>--- a/src/win32/specific.c
>+++ b/src/win32/specific.c
>@@ -76,8 +76,7 @@ void system_Init(void)
>     if (GetProcAddress(GetModuleHandle(TEXT("kernel32.dll")),
>                                   "SetDefaultDllDirectories") != NULL)
> # endif /* FIXME: not reentrant */
>-        LoadLibraryFlags = LOAD_LIBRARY_SEARCH_APPLICATION_DIR |
>-                           LOAD_LIBRARY_SEARCH_SYSTEM32;
>+        LoadLibraryFlags = LOAD_WITH_ALTERED_SEARCH_PATH;
> #endif
> }
> 
>-- 
>2.11.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Hey,

AFAIR, only vlc.exe sets the DLL path. Setting it in Libvlccore.dll is known to break some other libvlc-based apps (and in general, a library should not set process-wide parameters).

So I suspect that we cannot rely on that.
-- 
Rémi Denis-Courmont