[vlc-devel] [PATCH 3/3] core: win32: load dependent libraries in modules from System32 only

[Steve Lhomme]

On Fri, Mar 10, 2017 at 11:02 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On March 10, 2017 11:36:38 AM GMT+02:00, Steve Lhomme <robux4 at videolabs.io> wrote:
>>The modules are always loaded with an absolute path. So we should not
>>need anything else to load modules properly with their system
>>libraries.
>>---
>> src/win32/specific.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>>diff --git a/src/win32/specific.c b/src/win32/specific.c
>>index a39fae7251..e9b4eeef10 100644
>>--- a/src/win32/specific.c
>>+++ b/src/win32/specific.c
>>@@ -76,8 +76,7 @@ void system_Init(void)
>>     if (GetProcAddress(GetModuleHandle(TEXT("kernel32.dll")),
>>                                   "SetDefaultDllDirectories") != NULL)
>> # endif /* FIXME: not reentrant */
>>-        LoadLibraryFlags = LOAD_LIBRARY_SEARCH_APPLICATION_DIR |
>>-                           LOAD_LIBRARY_SEARCH_SYSTEM32;
>>+        LoadLibraryFlags = LOAD_LIBRARY_SEARCH_SYSTEM32;
>> #endif
>> }
>>
>>--
>>2.11.1
>>
>>_______________________________________________
>>vlc-devel mailing list
>>To unsubscribe or modify your subscription options:
>>https://mailman.videolan.org/listinfo/vlc-devel
>
> Does this work with dvdcss, aacs and the likes?

It should, and if it doesn't it should be fixed for these specific
cases that we control.

> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel